I committed my changes under the branch GL_WALLPAPER_SERVICE but am unable to upload it for review using "repo upload"
I get a publickey failure (seems like I don't have auth to do that). Who should I email to notify of the branch and then where can I look for help on finishing this? It's my first time contributing and I'd like to see this thing through. Thanks. On Jan 15, 3:32 pm, Romain Guy <[email protected]> wrote: > > I'm all set up. What branch should I submit this to? > > The branch would be master. > > > The reason I didn't just submit this is because one would think that > > nice integration would involve reuse instead of a copy of much of that > > code. If GLSurfaceView were refactored a bit, both it and GLEngine > > could share 99% of the code. I feel like that's stepping outside of > > my bounds as a contributor, though. I guess I'll submit this and > > suggest that GLSurfaceView be refactored to use a common code base > > with GLEngine. > > It's not out of bounds, far from it :) > > > > > > > > > On Jan 15, 1:37 pm, Romain Guy <[email protected]> wrote: > >> Hi, > > >> If you want to contribute to Android, please go > >> tohttp://s.android.comandfollow the instructions. > > >> On Fri, Jan 15, 2010 at 10:53 AM, Robert Green <[email protected]> wrote: > >> > Romain, > > >> > I adapted the code from GLSurfaceView into a GLWallpaperService/ > >> > GLEngine design and posted it here - > >> >http://www.rbgrn.net/content/354-glsurfaceview-adapted-3d-live-wallpa... > > >> > I'd like for your team to review it and consider adding it (with > >> > whatever modifications the API designers deem necessary) to the next > >> > version of Android. > > >> > With it, I was able to code my app up using a standard GLSurfaceView/ > >> > Renderer and then just move the Renderer over to the newLive > >> >Wallpaperapp without any problems. > > >> > It's currently being used in the appLiveWaterpaper on the market. > > >> > On Jan 11, 9:17 pm, Robert Green <[email protected]> wrote: > >> >> I guess I should have checked out the defaults first. Very good. > >> >> This will be a nice little break from the game programming. > > >> >> On Jan 11, 8:09 pm, Romain Guy <[email protected]> wrote: > > >> >> > Yes you can, all defaultlivewallpapers except one are implemented > >> >> > inGL. > > >> >> > On Mon, Jan 11, 2010 at 4:59 PM, Robert Green <[email protected]> > >> >> > wrote: > >> >> > > Can we useGLforlivewallpapers? I have a sweet idea for one that > >> >> > > won't hit the CPU/GPU too hard. > > >> >> > > -- > >> >> > > You received this message because you are subscribed to the Google > >> >> > > Groups "Android Developers" group. > >> >> > > To post to this group, send email to > >> >> > > [email protected] > >> >> > > To unsubscribe from this group, send email to > >> >> > > [email protected] > >> >> > > For more options, visit this group at > >> >> > >http://groups.google.com/group/android-developers?hl=en > > >> >> > -- > >> >> > Romain Guy > >> >> > Android framework engineer > >> >> > [email protected] > > >> >> > Note: please don't send private questions to me, as I don't have time > >> >> > to provide private support. All such questions should be posted on > >> >> > public forums, where I and others can see and answer them > > >> > -- > >> > You received this message because you are subscribed to the Google > >> > Groups "Android Developers" group. > >> > To post to this group, send email to [email protected] > >> > To unsubscribe from this group, send email to > >> > [email protected] > >> > For more options, visit this group at > >> >http://groups.google.com/group/android-developers?hl=en > > >> -- > >> Romain Guy > >> Android framework engineer > >> [email protected] > > >> Note: please don't send private questions to me, as I don't have time > >> to provide private support. All such questions should be posted on > >> public forums, where I and others can see and answer them > > > -- > > You received this message because you are subscribed to the Google > > Groups "Android Developers" group. > > To post to this group, send email to [email protected] > > To unsubscribe from this group, send email to > > [email protected] > > For more options, visit this group at > >http://groups.google.com/group/android-developers?hl=en > > -- > Romain Guy > Android framework engineer > [email protected] > > Note: please don't send private questions to me, as I don't have time > to provide private support. All such questions should be posted on > public forums, where I and others can see and answer them
-- You received this message because you are subscribed to the Google Groups "Android Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/android-developers?hl=en
