By the way, Jeff, regarding this...: On Wednesday 10:56 AM 8/20/2008, Jeff Rogers wrote:
And it still hurts the optimization of using a 404 adp page to generate a heavyweight file only once that gets cached.
...which you'd explained elsewhere as...:
There is also at least one clever optimization where "static" content does get served within a second of being created, where the 404 page is used to generate something like an image from something like a database and writes it to a file where it is subsequently served by fastpath.
...this fix doesn't break this functionality. You can still do it and it'll still work. And in fact, others have been arguing (and I believe you've been agreeing) that serving anything other than truly static content with ns_returnfile is immoral anyway--so it seems more than a bit contradictory to use that exact case to argue against the fix.
In any case, though, assuming that this once-generated heavyweight file is actually reused multiple times, it *will* be cached...just not for 1-2 seconds. I think the negligible cost of not having caching for just-created files for a period of 1-2 seconds is more than justified by the necessity to patch such a serious data corruption and security hole.
(I used two seconds out of an excess of caution, BTW; one would be sufficient.)
- John -- AOLserver - http://www.aolserver.com/ To Remove yourself from this list, simply send an email to <[EMAIL PROTECTED]> with the body of "SIGNOFF AOLSERVER" in the email message. You can leave the Subject: field of your email blank.
