Hi Chris,
> static void PDD_Name(Host_SetPaletteEntry)(ARMul_State *state,int i,unsigned
> int phys)
> {
> - int r = (phys & 0xf)*0x11;
> - int g = ((phys>>4) & 0xf)*0x11;
> - int b = ((phys>>8) & 0xf)*0x11;
> + ULONG r = ((phys & 0xf)*0x11) << 24;
> + ULONG g = (((phys>>4) & 0xf)*0x11) << 24;
> + ULONG b = (((phys>>8) & 0xf)*0x11) << 24;
> +
> IGraphics->SetRGB32(&screen->ViewPort,i,r,g,b);
> }
Before we were going from nibbles to bytes, 0xf -> 0xff, now it's 0xf ->
0xff00_0000. Shouldn't that be 0xffff_ffff, e.g.
ULONG r = ((phys & 0xf) * 0x11111111);
That way, we're still specifying the maximum possible to SetRGB32().
Same goes for the mouse cursor palette patch. Google turned up
http://amigadev.elowar.com/read/ADCD_2.1/Includes_and_Autodocs_3._guide/node0328.html
which also seems to suggest 0xffff_ffff is required.
Cheers, Ralph.
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2dcopy1
--
arcem-devel mailing list
arcem-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/arcem-devel
