Darrick Hartman (lists) wrote: > Philip Prindeville wrote: > >> So, who's trying to build from trunk lately, and what success are they >> having? >> >> There was some stuff checked in last night (or this morning) that I'd be >> interesting in hearing feedback on. >> > > Philip, > > I know I committed most of the last changes, but I hadn't had a chance > to build a new image until today. There appears to be some sort of > logic error in your arnofw shim. > > REAL_CONFIG_FILE="`dirname $CONFIG_FILE`/firewall.conf" > > I'm guessing that `dirname $CONFIG_FILE` was supposed to be replaced by > something during the build? >
No, it could expand out at run-time. But it might have been simpler to compute it at build time and put it in literally, I suppose. This is fixed with the newest diffs. > What are you trying to accomplish with the shim file anyway? Does it's > existence overwrite anything in the firewall.conf file? If we're not > going to move everything into rc.conf, I'd just as soon force people to > edit the one firewall.conf file rather than guess which settings are > coming from rc.conf and which are coming from the firewall.conf file. > > On the build side, everything else appears to have built cleanly. > > Darrick > I'm trying to have the values on /etc/rc.conf supersede the values in /etc/arno-iptables-firewall/firewall.conf whenever they overlap. Mainly because /etc/rc.conf is the "main source of truth" as I see it (especially if you're using the web interface to configure your system). Unfortunately, there are a lot more knobs that can be turned inside firewall.conf, so that will still need to be edited at least some of the time. Ideally, if we converged all of the variable names to be the same (and of course, the same semantics) then that would simplify a whole lot. The shim gets sourced immediately after firewall.conf, so it could read rc.conf and convert its values into the ones that the script expects, or at the very least compare the values in /etc/rc.conf for coherency with those in firewall.conf to make sure they both agree... and generate a warning telling you to edit the latter if they don't. -Philip ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Astlinux-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/astlinux-users Donations to support AstLinux are graciously accepted via PayPal to [EMAIL PROTECTED]
