Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

[Marc Gonzalez]

On 05/03/2024 15:31, Kalle Valo wrote:

> Thanks, this is exactly what I'm proposing.

With your suggestions, the patch becomes much simpler:

diff --git a/drivers/net/wireless/ath/ath10k/core.c 
b/drivers/net/wireless/ath/ath10k/core.c
index 0032f8aa892ff..18d0abcf6f693 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -769,6 +769,7 @@ static const char *const ath10k_core_fw_feature_str[] = {
        [ATH10K_FW_FEATURE_SINGLE_CHAN_INFO_PER_CHANNEL] = 
"single-chan-info-per-channel",
        [ATH10K_FW_FEATURE_PEER_FIXED_RATE] = "peer-fixed-rate",
        [ATH10K_FW_FEATURE_IRAM_RECOVERY] = "iram-recovery",
+       [ATH10K_FW_FEATURE_NO_MSA_READY] = "no-msa-ready",
 };
 
 static unsigned int ath10k_core_get_fw_feature_str(char *buf,
diff --git a/drivers/net/wireless/ath/ath10k/core.h 
b/drivers/net/wireless/ath/ath10k/core.h
index c110d15528bd0..1ac8ea02cc088 100644
--- a/drivers/net/wireless/ath/ath10k/core.h
+++ b/drivers/net/wireless/ath/ath10k/core.h
@@ -835,6 +835,9 @@ enum ath10k_fw_features {
        /* Firmware support IRAM recovery */
        ATH10K_FW_FEATURE_IRAM_RECOVERY = 22,
 
+       /* Firmware does not send MSA_READY indicator */
+       ATH10K_FW_FEATURE_NO_MSA_READY = 23,
+
        /* keep last */
        ATH10K_FW_FEATURE_COUNT,
 };
diff --git a/drivers/net/wireless/ath/ath10k/qmi.c 
b/drivers/net/wireless/ath/ath10k/qmi.c
index 38e939f572a9e..7e408fd63cdb8 100644
--- a/drivers/net/wireless/ath/ath10k/qmi.c
+++ b/drivers/net/wireless/ath/ath10k/qmi.c
@@ -1040,6 +1040,8 @@ static void ath10k_qmi_driver_event_work(struct 
work_struct *work)
                switch (event->type) {
                case ATH10K_QMI_EVENT_SERVER_ARRIVE:
                        ath10k_qmi_event_server_arrive(qmi);
+                       if (test_bit(ATH10K_FW_FEATURE_NO_MSA_READY, 
ar->running_fw->fw_file.fw_features))
+                               ath10k_qmi_event_msa_ready(qmi);
                        break;
                case ATH10K_QMI_EVENT_SERVER_EXIT:
                        ath10k_qmi_event_server_exit(qmi);



I need to build a kernel + rootfs + FW to test the proposed solution,
then I can spin a formal submission.

(I didn't understand why this patch requires Dmitry's series?)

Do I need to submit a symmetric patch to linux-firmware to define bit 23?
And also a patch to add the bit to some firmwares? (All msm8998 FWs?)

Regards