On Sat, 2008-11-08 at 18:02 -0500, Chris Frey wrote: > Hi Rick, > > Your latest CVS compiles against 2.6.26.5. > > I noticed you fixed a couple of errors in my previous patches. Thanks. > > > > We can't return ENODEV if the socket is 0 in desktop_open. In the case > > of a non-blocking open the socket will not yet have been set, but > > the open must succeed. This is needed for the serial protocol. The > > device must be opened, wait for DSR, then proceed. DSR gets set > > when the desktop socket is successfully opened. > > It seems that the new code still does return ENODEV if the socket is 0 > in desktop_open(). See line 345.
Oh ya, that part, right. If Desktop mode cannot be set it's NODEV. If we attempt to open_socket we do not necessarily wait for the socket to be opened if the file was opened NONBLOCK. So, socket may still be 0 when we leave open, which can be okay. > > - Chris ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Barry-devel mailing list Barry-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/barry-devel
