On Monday 06 August 2007, John W. Linville wrote: > On Sat, Aug 04, 2007 at 06:47:29PM +0200, Michael Buesch wrote: > > On Saturday 04 August 2007, Larry Finger wrote: > > > Pavel Roskin wrote: > > > > On Fri, 2007-08-03 at 20:46 -0500, Larry Finger wrote: > > > > > > > >> The size of LO array message is not fatal. > > > > > > > > I'll really appreciate if it's removed or at least the stack dump is > > > > suppressed. We know already that it's a problem, so why scare users > > > > more than they need to? We know where it happens, why show the stack? > > > > > > > > I don't think we want to make users ignore stack traces in the kernel > > > > logs, because we may not hear about unknown problems. > > > > > > > > IMHO there are better places for TODO notes than innocent users' kernel > > > > logs. > > > > > > I agree completely; however, I've had my "hands slapped" in the past for > > > removing that kind of > > > message. As a result, I leave them alone. > > > > Well, there are good reasons for not removing this. > > The resons include that this message is only shown for the debug build. > > So if you want it to shut up, don't compile a debug build. > > Is there a real need for the call to dump_stack on err? Isn't the > printk (bcmdbg) good enough?
Well, without a stacktrace you don't know who caused the error. We can remove that. But I still don't know what we gain from removing useful debug messages. If you don't care about bcm43xx bugs, simply disable bcm43xx debugging. _______________________________________________ Bcm43xx-dev mailing list [email protected] https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
