Michael Buesch wrote:
>
> Well, without a stacktrace you don't know who caused the error.
> We can remove that. But I still don't know what we gain from
> removing useful debug messages. If you don't care about bcm43xx bugs, simply
> disable bcm43xx debugging.
Michael, I agree with you in general, but in this case we know that the line
"bbatt.att = 11" in
bcm43xx_phy_init_pctl leads to this error message. Why don't we change it to
'bbatt.att = 8' to
eliminate this particular error message? That way the debugging info can stay
in without polluting
everyone's log.
Larry
The patch is:
Index: wireless-dev/drivers/net/wireless/bcm43xx-mac80211/bcm43xx_phy.c
===================================================================
--- wireless-dev.orig/drivers/net/wireless/bcm43xx-mac80211/bcm43xx_phy.c
+++ wireless-dev/drivers/net/wireless/bcm43xx-mac80211/bcm43xx_phy.c
@@ -725,7 +725,7 @@ static void bcm43xx_phy_init_pctl(struct
memcpy(&old_bbatt, &phy->bbatt, sizeof(old_bbatt));
old_tx_control = phy->tx_control;
- bbatt.att = 11;
+ bbatt.att = 8;
if (phy->radio_rev == 8) {
rfatt.att = 15;
rfatt.with_padmix = 1;
_______________________________________________
Bcm43xx-dev mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
