On Monday 06 August 2007, Larry Finger wrote: > Michael Buesch wrote: > > > > Well, without a stacktrace you don't know who caused the error. > > We can remove that. But I still don't know what we gain from > > removing useful debug messages. If you don't care about bcm43xx bugs, simply > > disable bcm43xx debugging. > > Michael, I agree with you in general, but in this case we know that the line > "bbatt.att = 11" in > bcm43xx_phy_init_pctl leads to this error message. Why don't we change it to > 'bbatt.att = 8' to > eliminate this particular error message? That way the debugging info can stay > in without polluting > everyone's log.
Because that would simply be plain wrong. The specs says we have to write 11. So we write 11 and not something else to workaround bugs in other parts of the code. I don't feel comfortable with introducing bugs to hide other bugs. Someone must reverse engineer all that stuff again. But currently we have nobody with enough time to do this. _______________________________________________ Bcm43xx-dev mailing list [email protected] https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
