>NULL should not be an option in the albums table compilation field. > Haven't checked, but doesn't the DB currently hold NULL when an album is not a compilation? Could changing this to default to 0 be a problem for other queries in the app?
>The major thing that this logic omits is the assignment of track artist >roles. I firmly believe that there is no need for this role and that it >can be eliminated. > Is this not used at all anywhere, even when changing some of the Settings > My Music options? >Goals: > >1. Mark album as either a compilation or non-compilation. Set the >field 'compilation' in table 'album' to 1 or 0. > >2. Set album artist roles in 'contributors_album' to at least one row >from the table 'contributors'. > Agreed (except potentially 1 or NULL for compilation). > COMPILATION tag? > 1 > Set compilation=1 > ALBUMARTIST tag(s)? > PRESENT > Set album artist(s) to contributor(s) in ALBUMARTIST tag(s) > NOT PRESENT > Set album artist to the VA pseudo-artist I think this should result in the logic based on checking track artists. Not related to COMPILATION tag value. If someone tags "Queen greatest hits" as a compilation, then it's a compilation by Queen if all songs are performed by queen, otherwise VA. > 0 > Set compilation=0 Is this valid? Only case I can think of is if there are two album rips with the same album name in the same music folder. Compilation=0 forces them apart to be two albums, rather than one big compilation album - is that still the case and would need supporting in the logic below? I'm sure Comp=0 caused loads of issues at one point. Most people only tag when an album is a comp, not when it isn't, hence DB usually holds a NULL value. > NOT PRESENT > ALBUMARTIST tag(s)? > PRESENT > Set compilation=0 > Set album artist(s) to contributor(s) in ALBUMARTIST tag(s) I think this scenario currently causes one album per unique set of artists on the songs in the folder, rather than one album by lots of contributors. e.g. two different "Greatest Hits" albums ripped to one folder. _______________________________________________ beta mailing list [email protected] http://lists.slimdevices.com/mailman/listinfo/beta
