Re: [blfs-dev] javaws.png

[Fernando de Oliveira]

On 25-08-2014 20:00, Bruce Dubbs wrote:
> Fernando de Oliveira wrote:
>> On 25-08-2014 15:21, Armin K. wrote:
>>
>>>
>>> Please try to limit line length. We don't want "infinite" lines in xml
>>> files.
>>
>> Completely agree.
> 
> Partially agree.  In general it's good to keep lines to less than 80
> columns, but exceptions are OK too.
> 
>   -- Bruce

Yes, as I used to be part time programmer for my main profession, I
never let it reach even 80. So I try to do here, in xml. But an out of
place acid comment can cause a caustic reply.



I have just finished writing a small script and can now get the lines
longer than 80 characters in openjdk.xml, finally:

Considering the number of lines = 1255, it is not easy to find the
offensive(s) line(s)

Below, first collumn is line number, second is number of characters,
third is the line itself.

Considering the comment came after my commit, I believe the lines that I
forgot to break are 537 (172 characters) and 394 (205), although to be
strict, many others should be modified.

I think that line 396 (169 characters):

<screen role="root"><userinput>tar -xf
../icedtea-web-&icedtea-web-version;.tar.gz
icedtea-web-&icedtea-web-version;/javaws.png
--strip-components=1</userinput></screen>

perhaps could be broken:

<screen role="root"><userinput>tar -xf
../icedtea-web-&icedtea-web-version;.tar.gz \
  icedtea-web-&icedtea-web-version;/javaws.png \
  --strip-components=1</userinput></screen>

but I am not sure if it would look nice.

I will change all three, and wait for comments.

"OpenJDK-1.7.0.65/IcedTea-2.5.1: break some lines to less than 80
columns - first attempt." Committed revision 14081.

DATA:
Sorted by increasing numbers of characters.

$ ~/sshfs/blfs/display-lines-greater-than-80.sh openjdk.xml
461 81 <sect2 role="configuration" id="openjdk-config"
xreflabel="Configuring OpenJDK" >
788 81 -s "/usr/bin/openssl" -o
"/opt/jdk/jre/lib/security/cacerts"</userinput></screen>
108 82 <ulink
url="http://openjdk.java.net/groups/conformance/JckAccess/jck-access.html";>
654 82 echo "                            certificates.  May not be used
with -d/--cadir."
656 83 echo "                            certificates.  May not be used
with -f/--cafile."
486 84 <screen role="root"><userinput>cat &gt;&gt;
/etc/profile.d/openjdk.sh &lt;&lt; "EOF"
49 84 <sect1 id="openjdk"
xreflabel="OpenJDK-&openjdk-version;/IcedTea-&icedtea-version;">
761 84 echo yes | env LC_ALL=C "${KEYTOOL}" -import -alias `basename
"${cert}"` -keystore \
46 88 <!ENTITY openjdk-time                  "26-27 SBU (an additional
90 SBU for testsuite)">
542 90 <title>Install or update the JRE Certificate Authority
Certificates (cacerts) file</title>
350 91 <screen><userinput>unset JAVA_HOME
                &amp;&amp;
520 92 <screen role="root"><userinput>cat >>
/etc/profile.d/extrapaths.sh &lt;&lt; "EOF" &amp;&amp;
390 95 <screen role="root"><userinput>chmod 0644
openjdk.build/j2sdk-image/lib/sa-jdi.jar   &amp;&amp;
41 99 <!ENTITY rhino-download
"https://github.com/downloads/mozilla/rhino/rhino1_7R4.zip";>
344 100 <screen><userinput>patch -Np1 -i
../icedtea-&icedtea-version;-fix_tests-1.patch</userinput></screen>
473 101 <screen role="root"><userinput>ln -v -nsf
OpenJDK-&openjdk-version;-bin /opt/jdk</userinput></screen>
331 102 <screen><userinput>patch -Np1 -i
../icedtea-&icedtea-version;-add_cacerts-1.patch</userinput></screen>
336 102 <screen><userinput>patch -Np1 -i
../icedtea-&icedtea-version;-fixed_paths-1.patch</userinput></screen>
787 103 <screen role="root"><userinput>/opt/jdk/bin/mkcacerts -d
"/etc/ssl/certs/"  -k "/opt/jdk/bin/keytool" \
340 105 <screen><userinput>patch -Np1 -i
../icedtea-&icedtea-version;-fix_new_giflib-1.patch</userinput></screen>
7 113 <!ENTITY anduin-download
"http://anduin.linuxfromscratch.org/files/BLFS/OpenJDK-&openjdk-version;";>
8 119 <!ENTITY icedtea-download
"http://icedtea.classpath.org/download/source/icedtea-&icedtea-version;.tar.xz";>
400 122 <screen role="root"><userinput>cat &gt;&gt;
/usr/share/applications/openjdk-7-policytool.desktop &lt;&lt; "EOF"
&amp;&amp;
396 169 <screen role="root"><userinput>tar -xf
../icedtea-web-&icedtea-web-version;.tar.gz
icedtea-web-&icedtea-web-version;/javaws.png
--strip-components=1</userinput></screen>
537 172 <para>To test the man pages are correctly installed, issue
<command>source /etc/profile</command> and <command>man java</command>
to display the respective man page.</para>
394 205 <para>If desired, you may install a .desktop file corresponding
to an entry in a desktop menu for <command>policytool</command>. First,
you need to obtain an icon from <xref linkend="icedtea-web"/>:</para>



-- 
[]s,
Fernando
-- 
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page