On Fri, Sep 28, 2018 at 11:04:57AM -0500, Bruce Dubbs via blfs-dev wrote:
> On 09/28/2018 10:25 AM, spiky via blfs-dev wrote:
> >
> >
> > On 28/09/18 14:53, Douglas R. Reno wrote:
> > >
> > >
> > > On Fri, Sep 28, 2018 at 6:16 AM spiky via blfs-dev
> > > <[email protected]
> > > <mailto:[email protected]>> wrote:
> > >
> > > Just building vala-0.42.0 and found graphviz is a required dep, not
> > > recommended.
> > >
> > > "No package 'libgvc' found" Unless there is a work around for this.
> > >
> > > You probably should install graphviz.
> > >
> > > There was some discussion on this recently, initiated by Ken. Ken
> > > found a workaround for the sed, I think it was increasing the values
> > > by 7 lines? That was the original reason why it was recommended.
> > >
> > > My only problem with this is that I have to tweak it every release,
> > > and the number is always different. That being said, I can enlist
> > > someone else's help every time it comes out with a new minor version
> > > as well.
> > >
> > > For reference, Vala needs graphviz for the valadoc command.
>
> > Then shouldn't be changed to required instaed of recommended
>
> We should be able to disable valadoc during the build. Most of our users
> don't need it.
>
> I have not built the latest, but for version 0.40.8 I used
>
> sed -i '115d; 121,137d; 139,140d' configure.ac &&
> sed -i '/valadoc/d' Makefile.am &&
> ACLOCAL= autoreconf -fiv
>
> For the editors, figuring out those line numbers is a bit of a pain, but I
> think it is a service to the users.
>
for 42.0,
sed -i '122d; 128,144d; 146,147d' configure.ac
sed -i '/valadoc/d' Makefile.am
ACLOCAL= autoreconf -fiv
For that, I applied the seds to a copy of the OLD tree, to get a
patch that I could look at.
A comparison to the new tree showed what seemed to be the same block
of code, but further down. This is why I say that whilst using
patches doesn't allow editors to show off their leet sed skillz, it
is much easier to carry forward.
On this occasion I amended my own build script rather than making a
patch for 0.42, because 0.42 will presumably be around for some
time.
> I have used doxygen when I was doing development work and that needed a full
> graphviz, so I tend to want to build all optional graphviz dependencies,
> That does make graphviz a pain. If possible, I prefer to allow users to
> opt out of documentation that they are not interested in.
>
Agreed
> The bottom line is that I would prefer to modify the build and make valadoc
> (and graphviz) optional and not recommended.
>
The problem when the sed is not present is that they become
required, not recommended. If a package allows --disable-big-thing
or -Dbig_thing=NO then recommending is fine, people can look at
configure/cmake/meson and find the option if they don't want it.
ĸen
--
Tout est bien, tout va bien, tout va pour le mieux qu'il soit possible
-- Candide, de Voltaire
(Everything is for the best, in the best of all possible worlds)
--
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
