On Mon, Jan 27, 2025 at 2:56 AM Domenic Denicola <dome...@chromium.org> wrote:
> This overall seems promising, but a few inline comments. The only blocking > one is the question about open spec edits. > > On Thursday, January 23, 2025 at 4:42:34 AM UTC+9 Chromestatus wrote: > > Contact emails nrosent...@chromium.org > > Explainer None > > > I was able to piece together an explainer by looking through the spec and > its examples. In the future, pointing to them a bit more directly, or > pulling them out into a paragraph or two, would be helpful. > Aye. Since the spec was written before the explainer trend (2020-ish) I thought it would be more useful if the spec explained itself... > > > Debuggability > > None > > > Do we currently have any special DevTools support for clip-path()? If so, > we might want to consumer the same thing for shape(). > We do not. I've updated the debuggability section, there is an open bug for this: https://issues.chromium.org/issues/40787656 > > > > Will this feature be supported on all six Blink platforms (Windows, Mac, > Linux, ChromeOS, Android, and Android WebView)? Yes > > Is this feature fully tested by web-platform-tests > <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> > ? Yes > > https://wpt.fyi/results/css/css-shapes/shape-functions?label=master&label= > experimental&aligned&q=shape (anything beginning with shape-) > https://wpt.fyi/results/css/css-masking/clip-path?label= > master&label=experimental&aligned&q=shape and https://wpt.fyi/results/css/ > css-masking/clip-path/animations?label=master&label= > experimental&aligned&q=shape (clip-path-shape-*) > > > Flag name on about://flags CSSShapeFunction > > > I don't think this is an about://flags flag. (At least, I don't see one in > my Chrome Dev.) Probably it's best to remove this from ChromeStatus. > Aye, removing. > > > > > Finch feature name CSSShapeFunction > > Requires code in //chrome? False > > Tracking bug https://issues.chromium.org/issues/40829059 > > Estimated milestones Shipping on desktop 135 DevTrial on desktop 134 Shipping > on Android 135 DevTrial on Android 134 Shipping on WebView 135 > > Anticipated spec changes > > Open questions about a feature may be a source of future web compat or > interop issues. Please list open issues (e.g. links to known github issues > in the project for the feature specification) whose resolution may > introduce web compat/interop risk (e.g., changing to naming or structure of > the API in a non-backward-compatible way). > None > > > https://github.com/w3c/csswg-drafts/labels/css-shapes-2 has quite a lot > of open issues. Several of them relate to shape(), I believe: > > - https://github.com/w3c/csswg-drafts/issues/11358 > > This is going to be asynchronously resolved in the next day or two. The resolution is purely technical as it reflects what both WebKit & Chromium implemented and already tested in the WPTs. > > - https://github.com/w3c/csswg-drafts/issues/10697 > - https://github.com/w3c/csswg-drafts/issues/10644 > > I've closed these, it's leftovers for things that were fixed in one bulk PR. > > - https://github.com/w3c/csswg-drafts/issues/10647 > > This one is not actionable and doesn't affect shape(), it's about path(). > > - https://github.com/w3c/csswg-drafts/issues/10667 > > We might do this in the future, but it would be compatible with the current spec. > Could you comment on these (and any others I might have missed) to let us > know if any of them reflect either (a) potential backward-incompatible > changes (#10647 seems especially scary in that regard), or (b) mismatches > between the currently live spec and our implementation? If they are just > potential future backward-compatible enhancements then that's fine, but I > can't tell at a glance whether that's the case for all of them. > See above, none of these would have backwards compatibility issues. As far as the spec goes the feature is complete. -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAJn%3DMYZVwLLupXTdscSqDbfs9vjuwoq-_kdm93OOyN3P%3D-HKHg%40mail.gmail.com.
