#195: Attach file form à la GMail
--------------------------+---------------------------------------
Reporter: jdreimann | Owner:
Type: enhancement | Status: assigned
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords: attachments inplace html5
--------------------------+---------------------------------------
Changes (by olemis):
* keywords: => attachments inplace html5
* status: needinfo => assigned
Comment:
I've refreshed previous patches to be applied against r1404963 . Also some
more for theme plugin have been added (see [comment:9 patch order] for
further details) . They improve current situation by unifying file lists .
Enhanced handling for collisions and overwritten has been added in both
server-side request handler as well as client side.
Replying to [comment:13 jdreimann]:
> Replying to [comment:11 olemis]:
> > Pending issues
> > - Question: What is it that should happen in the UI after
overwriting an
> > existing attachment ?
> Instead of 'added by [...]' (eg on the ticket page) it should say
'**updated** by [...]'.
I didn't implement this since I decided to be a little lazy to ensure this
is what we want for this to happen . At present the behavior introduced by
patches is as follows . If attachment is overwritten (i.e. another file
with the same name already exists in the server) then the following
transition occur
- On clicking upload , once it's done then `template-upload` file row
fades out
- Then corresponding `template-download` row fades in to replace the
former
- Previous `template-download` row for initial attachment slides up
until it
disappears
- The later is removed from DOM .
It seems to me that such combination is smooth enough and deserves at
least to be considered .
Question :
- We should not remove previous attachment row on error ... isn't it ?
> > - Determine the definitive name of the attachment (e.g. when
> > file of the same name exists but it won't be overwritten)
Finally I could figure out how to get this done .
After all this been said , this is quite ready ... please review .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/195#comment:15>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
