[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476059#comment-13476059
 ] 

Sijie Guo commented on BOOKKEEPER-431:
--------------------------------------

seems that we had BOOKIE_COOKIE_PATH first in Cookie.java. then a fix to 
exclude Cookie znode from GC introduced COOKIES_NODE in 
AbstractZkLedgerManager. Then BOOKKEEPER-263 remove hard coded path introduced 
COOKIE_NODE in Cookie.java.

I agreed that it would be better to maintain constants in single place to avoid 
duplications.
                
> Duplicate definition of COOKIES_NODE
> ------------------------------------
>
>                 Key: BOOKKEEPER-431
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-431
>             Project: Bookkeeper
>          Issue Type: Improvement
>    Affects Versions: 4.1.0
>            Reporter: Flavio Junqueira
>            Assignee: Uma Maheswara Rao G
>            Priority: Minor
>             Fix For: 4.2.0
>
>
> Is it necessary two definitions of COOKIES_NODE, one in cookie.java and one 
> in AbstractZkLedgerManager?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to