[
https://issues.apache.org/jira/browse/BOOKKEEPER-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511558#comment-13511558
]
Sijie Guo commented on BOOKKEEPER-431:
--------------------------------------
Agreed that we don't need to move configuration settings from Configuration to
Constants.
besides that, one minor comment:
{quote}
public static final String ZK_LEDGERS_ROOT_PATH_DEFAULT = "/ledgers";
{quote}
how about DEFAULT_ZK_LEDGERS_ROOT_PATH rather than ZK_LEDGERS_ROOT_PATH_DEFAULT
?
> Duplicate definition of COOKIES_NODE
> ------------------------------------
>
> Key: BOOKKEEPER-431
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-431
> Project: Bookkeeper
> Issue Type: Improvement
> Affects Versions: 4.1.0
> Reporter: Flavio Junqueira
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-431.patch
>
>
> Is it necessary two definitions of COOKIES_NODE, one in cookie.java and one
> in AbstractZkLedgerManager?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
