[
https://issues.apache.org/jira/browse/BOOKKEEPER-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511413#comment-13511413
]
Flavio Junqueira commented on BOOKKEEPER-431:
---------------------------------------------
Thanks, Uma. The patch looks mostly good to me and I just have one comment. I
was actually thinking that the we shouldn't move the configuration strings in
AbstractConfiguration, ClientConfiguration, and ServerConfiguration to
BookKeeperConstants. They belong in the respect configuration classes and I
don't expect them to be accessed elsewhere. What do you think?
> Duplicate definition of COOKIES_NODE
> ------------------------------------
>
> Key: BOOKKEEPER-431
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-431
> Project: Bookkeeper
> Issue Type: Improvement
> Affects Versions: 4.1.0
> Reporter: Flavio Junqueira
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-431.patch
>
>
> Is it necessary two definitions of COOKIES_NODE, one in cookie.java and one
> in AbstractZkLedgerManager?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
