[
https://issues.apache.org/jira/browse/BOOKKEEPER-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511580#comment-13511580
]
Uma Maheswara Rao G commented on BOOKKEEPER-431:
------------------------------------------------
Thanks Flavio and Sijie for taking a look.
I don't have any strong reason to move them to Consts for Configs. Just
followed like in Hadoop how I used to refer the config items for Const file.
For name also same reason I think.
ex. see Hadoop config name: :-)
{code}
public static final String DFS_STREAM_BUFFER_SIZE_KEY =
"dfs.stream-buffer-size";
public static final int DFS_STREAM_BUFFER_SIZE_DEFAULT = 4096;
{code}
I addressed thse 2 comments in this patch.
> Duplicate definition of COOKIES_NODE
> ------------------------------------
>
> Key: BOOKKEEPER-431
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-431
> Project: Bookkeeper
> Issue Type: Improvement
> Affects Versions: 4.1.0
> Reporter: Flavio Junqueira
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-431-1.patch, BOOKKEEPER-431.patch
>
>
> Is it necessary two definitions of COOKIES_NODE, one in cookie.java and one
> in AbstractZkLedgerManager?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
