[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529717#comment-13529717
]
Sijie Guo commented on BOOKKEEPER-463:
--------------------------------------
one minor comment about this patch. I found it when writing the document for
bookkeeper metadata management.
{quote}
{@link BKException.Code.ZKException} is returned when can't generate or extract
new
+ * ledger id issues happen
{quote}
I saw 'BKException.Code.ZKException' added for each interface's comment in
LedgerManager. for a zookeeper based implementation, it throws ZKException
might be make sense. for other implementation, it doesn't make sense. I suppose
we should throw a more generic like MetadataStoreException to indicate it was
failures from metadata store.
Could you help confirmed what kind of exception it thrown in zookeeper-based
implementation and the callers of LedgerManager how they interpreted the
exceptions?
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-463.patch, BOOKKEEPER-463.patch,
> BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch,
> BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch,
> BOOKKEEPER-463.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
