[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536852#comment-13536852
]
Sijie Guo commented on BOOKKEEPER-463:
--------------------------------------
1. Created BOOKKEEPER-521 tracking the issue.
2. getChildrenInSingleNode will not return null. an exception is thrown when it
failed to fetch entries from ZooKeeper.
>> In general, the problem I see with this approach is that it is hard to
>> guarantee that all implementations of LedgerManager#getLedgerRanges will do
>> the right thing.
for most of interfaces, you could not guarantee the right implementation. so
the implementation of this interface should take care of it, right?
3. removeLedgerMetadata. for two cases, they are same, using a wrong version.
so different messages would be better.
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.2.0
>
> Attachments:
> 0001-BOOKKEEPER-463-Refactor-garbage-collection-code-for-.patch,
> BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch,
> BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch,
> BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
