[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534909#comment-13534909
]
Flavio Junqueira commented on BOOKKEEPER-463:
---------------------------------------------
Here are some comments and questions about this patch:
# ScanAndCompareGarbageCollector.java. "to find those ledgers aren't existed"
-> "to find the ledgers that aren't in"
# ScanAndCompareGarbageCollector.java. Is it possible that
ledgerManager.getLedgerRanges(); returns an empty iterator in the case of an
error? I'm worried that this block "if (!ledgerRangeIterator.hasNext())..."
could end up deleting all active ledgers by mistake".
# removeLedgerMetadata. There are two cases in which we return
BKException.Code.MetadataVersionException and we don't give any more
information. It would be good to give a better hint on what the actual error
was.
# HierarchicalLedgerManager.java. "failed to get children list of a too big
znode during garbage collection." -> "errors during garbage collection due to
lists of children that are too long."
# LedgerManager.java. This sentence is broken:
{noformat}
+ * {@link BKException.Code.ZKException} is returned when can't generate or
extract new
+ * ledger id issues happen
{noformat}
should we remove "issues happen"?
# There are several instances of "is returned". Should we just say instead
"returned" or change the wording so that we can switch to active voice?
There is one general naive question I have and it is related to this patch. We
have both a meta package and metastore package. ZooKeeper is used in the meta
package, but not in the metastore package. Isn't ZK an option to store ledger
metadata? I suppose that the rationale is that the metastore package is really
for database-like stores, and excludes options like ZooKeeper.
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.2.0
>
> Attachments:
> 0001-BOOKKEEPER-463-Refactor-garbage-collection-code-for-.patch,
> BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch,
> BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch,
> BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
