[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13535688#comment-13535688
]
Sijie Guo commented on BOOKKEEPER-463:
--------------------------------------
{code}
We have both a meta package and metastore package. ZooKeeper is used in the
meta package, but not in the metastore package.
{code}
meta package is used to manage all bookkeeper related metadata, while metastore
package is supposed to provided a common metadata storage interface for both
bookkeeper meta and hedwig meta management. A better structure is that version
package and metastore package could be moved to a generic module, something
like 'bookkeeper-common'. bookkeeper-server and hedwig-server use
'bookkeeper-common' module.
for ZooKeeper, it is because we have ZooKeeper implementation before metastore
interface. so we have ZooKeeper specific implementation in the meta package
under bookkeeper and hedwig. I think we could implement ZooKeeper based
metadata storage using metastore interface (but maybe not, need to try) in
future to make code base clearly.
>> for the comments
I think [~lvfangmin] or [~jiannan] might not have time looking at this
recently. so [~ikelly] Could you help addressing the comments, since the latest
patch is rebased by you :-)
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.2.0
>
> Attachments:
> 0001-BOOKKEEPER-463-Refactor-garbage-collection-code-for-.patch,
> BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch,
> BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch,
> BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
