[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620827#comment-13620827
 ] 

Ivan Kelly commented on BOOKKEEPER-596:
---------------------------------------

Actually, by accident the current implementation handles those below the lower 
bound also. I agree with Jiannan's comment about removing the dependency on 
LedgerRange construction. During LedgerRange construction, the entity creating 
the LedgerRange shouldn't have to know how it will be used. The NOLIMIT 
constant indicates that they do. It would be cleaner if LedgerRange only took 
the list of ledgers and it worked out the first and last from that. Then the gc 
should decide how to use the ranges by itself.
                
> Ledgers are gc'ed by mistake in MSLedgerManagerFactory.
> -------------------------------------------------------
>
>                 Key: BOOKKEEPER-596
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-596
>             Project: Bookkeeper
>          Issue Type: Bug
>    Affects Versions: 4.2.0, 4.2.1
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>            Priority: Blocker
>             Fix For: 4.3.0
>
>         Attachments: BOOKKEEPER-596.patch, BOOKKEEPER-596.patch, 
> BOOKKEEPER-596.patch
>
>
> details: 
> https://issues.apache.org/jira/browse/BOOKKEEPER-590?focusedCommentId=13616397&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13616397

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to