[
https://issues.apache.org/jira/browse/BOOKKEEPER-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621004#comment-13621004
]
Jiannan Wang commented on BOOKKEEPER-596:
-----------------------------------------
Thanks Ivan for providing a new patch and add corresponding test case. Things
need to be taken very very careful for this fix. The patch looks good to me and
passes test in my dev box.
However, I find another legacy potential problem when review code: if there is
any error happen during gc we should throw exception to avoid incorrect gc, but
MSLedgerManagerFactory#MSLedgerRangeIterator#hasNext() eats a
InterruptedException and just return false.
Ivan, could you help to resolve the legacy problem?
> Ledgers are gc'ed by mistake in MSLedgerManagerFactory.
> -------------------------------------------------------
>
> Key: BOOKKEEPER-596
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-596
> Project: Bookkeeper
> Issue Type: Bug
> Affects Versions: 4.2.0, 4.2.1
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Priority: Blocker
> Fix For: 4.3.0
>
> Attachments:
> 0001-BOOKKEEPER-596-Ledgers-are-gc-ed-by-mistake-in-MSLed.patch,
> BOOKKEEPER-596.patch, BOOKKEEPER-596.patch, BOOKKEEPER-596.patch
>
>
> details:
> https://issues.apache.org/jira/browse/BOOKKEEPER-590?focusedCommentId=13616397&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13616397
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
