[
https://issues.apache.org/jira/browse/BOOKKEEPER-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625107#comment-13625107
]
Jiannan Wang commented on BOOKKEEPER-438:
-----------------------------------------
Thanks for reviewing code.
1. Actually I remove it from my previous patch, since I think we don't need to
specify them in code unless for testing purpose. And for testing, it seems
original bookkeeper's code practice is overwriting
AbstractConfiguration#getXXX. Is there any other usage for the setXXX?
2. Good point. For FlatLedgerManager, I assume the user would still use
previous ledger id generation fashion. In this way, the "zkLedgerIdGenPath"
conf is set to previous ledger path and then the start ledger id will continue
from last max ledger id. But if the user wants to use other ledger id
generation, we need more works on it. And I would suggest user migrate from
FlatLedgerManager to other better ledger manager and we provide such migration
tool. I think this might more useful, what is your opinion?
> Move ledger id generation out of LedgerManager
> ----------------------------------------------
>
> Key: BOOKKEEPER-438
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-438
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server, hedwig-server
> Reporter: Sijie Guo
> Assignee: Jiannan Wang
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-438.patch, BOOKKEEPER-438.patch,
> BOOKKEEPER-438.patch, BOOKKEEPER-438.patch, BOOKKEEPER-438.patch,
> BOOKKEEPER-438.patch, BOOKKEEPER-438.patch, BOOKKEEPER-438.patch
>
>
> Move id generation out of LedgerManager to ensure different ledger manager
> implementation shared same ledger id space in ZooKeeper, which is necessary
> for migration between different ledger managers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
