[
https://issues.apache.org/jira/browse/BOOKKEEPER-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625709#comment-13625709
]
Sijie Guo commented on BOOKKEEPER-438:
--------------------------------------
{code}
1. Actually I remove it from my previous patch, since I think we don't need to
specify them in code unless for testing purpose. And for testing, it seems
original bookkeeper's code practice is overwriting
AbstractConfiguration#getXXX. Is there any other usage for the setXXX?
{code}
for now, most of set* methods are used for test cases. but since these settings
are used by clients, providing set* methods is easy for applications which use
bookkeeper client. And for style consistency, it would be better to provide
set* methods :)
{code}
And I would suggest user migrate from FlatLedgerManager to other better ledger
manager and we provide such migration tool. I think this might more useful,
what is your opinion?
{code}
we discussed the migration tool before. if the ledger managers use different
ledger generator, they might produce same ledger id, which might make migration
complex and difficult to handle. And I think for FlatLedgerManager, it bounds
ledger id generator tightly with ledger metadata management. so it seems that
we need to have a tool to separate its ledger id generation from ledger
metadata management first and then proceed on its migration from
FlatLedgerManager to HierarchicalLedgerManager.
but anyway, I agreed that we should have a such migration framework or tool to
handle metadata migration and upgrade.
> Move ledger id generation out of LedgerManager
> ----------------------------------------------
>
> Key: BOOKKEEPER-438
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-438
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server, hedwig-server
> Reporter: Sijie Guo
> Assignee: Jiannan Wang
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-438.patch, BOOKKEEPER-438.patch,
> BOOKKEEPER-438.patch, BOOKKEEPER-438.patch, BOOKKEEPER-438.patch,
> BOOKKEEPER-438.patch, BOOKKEEPER-438.patch, BOOKKEEPER-438.patch
>
>
> Move id generation out of LedgerManager to ensure different ledger manager
> implementation shared same ledger id space in ZooKeeper, which is necessary
> for migration between different ledger managers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
