[
https://issues.apache.org/jira/browse/BOOKKEEPER-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13808235#comment-13808235
]
Ivan Kelly commented on BOOKKEEPER-696:
---------------------------------------
What I want to avoid is that when I'm working on something new and I want to
add a metric, I first have to track down the correct stats logger class, then
find the enum, add it and then jump back. There's times that I want to add a
stat for 2 minutes to debug, and this cycle is too long. For me, stats should
be like logging.
How about this. We have 2 files, one for client, one for server, (maybe a
separate for proto, but i think proto should be split into server and client).
These files, contain a list of 'final static String <STAT_CONST_NAME> =
"<readable_name>";'. This meets both aims of having them defined in one spot,
but also also allowing a stat to be added quickly for debugging/testing. And it
also means that the StatsLogger interface is used everywhere, rather than
facading it all over the place.
Re: builder, im fine with moving it to another task, but make the task a
blocker and leave a big noisy note on the new constructor that its not going to
be there for long.
> stats collection on bookkeeper client
> -------------------------------------
>
> Key: BOOKKEEPER-696
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-696
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-client
> Reporter: Sijie Guo
> Assignee: Aniruddha
> Fix For: 4.3.0
>
> Attachments: 0001-client-stats-for-bookkeeper.patch
>
>
> Stats for bookkeeper client.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
