[
https://issues.apache.org/jira/browse/BOOKKEEPER-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13873150#comment-13873150
]
Sijie Guo commented on BOOKKEEPER-696:
--------------------------------------
[~ikelly] to move on, let's keep the interface unchanged. I am ok with using
string directly in your attached patch.
several comments on your patch:
- please keep the string name same as the original enum name, respecting to
first patch.
- getOpStatsLogger or getCounter will generate a new object. it is really bad
that each bookkeeper op generate a new object just for stats, which would
double object creations on jvm. so it means that we still need a mapping
between name to corresponding OpStatsLogger/Counter (which is almost similar as
what we did in our patch).
> stats collection on bookkeeper client
> -------------------------------------
>
> Key: BOOKKEEPER-696
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-696
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-client
> Reporter: Sijie Guo
> Assignee: Aniruddha
> Fix For: 4.3.0
>
> Attachments: 0001-client-stats-for-bookkeeper.patch,
> 0002-BOOKKEEPER-696-stats-collection-on-bookkeeper-client.patch
>
>
> Stats for bookkeeper client.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
