[
https://issues.apache.org/jira/browse/BOOKKEEPER-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13810177#comment-13810177
]
Ivan Kelly commented on BOOKKEEPER-696:
---------------------------------------
If for each stat category we have to reimplement the statslogger, it certainly
will. I don't want to put this aside now, as this patch will define how we go
forward w.r.t. stat collection, and as the upcoming changes will change
performance, I want to be able to measure them before they go in.
However, I have a last suggestion, which uses enums, but which I also find
palatable. How about if StatsLogger, instead of taking a String, takes an Enum.
With this, each component that needs to log can directly to StatsLogger, yet we
can restrict the stat names being logged to a member enum. All enums for the
client can be put in one place.
I've coded this up:
https://github.com/ivankelly/bookkeeper/commits/stats-new-api
The commits to pay attention to are 3da604b0617b00908b52d7638683f5ed73e4264d &
37f7e151a7073132665ceb72ce9b1e21484cc3c1.
> stats collection on bookkeeper client
> -------------------------------------
>
> Key: BOOKKEEPER-696
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-696
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-client
> Reporter: Sijie Guo
> Assignee: Aniruddha
> Fix For: 4.3.0
>
> Attachments: 0001-client-stats-for-bookkeeper.patch,
> 0002-BOOKKEEPER-696-stats-collection-on-bookkeeper-client.patch
>
>
> Stats for bookkeeper client.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
