---------- Forwarded message ---------- From: Christopher Sean Morrison <[email protected]> Date: 31 May 2013 00:31 Subject: Re: [brlcad-devel] GSoC applicants To: Jasleen Kaur <[email protected]>
Hi Jasleen, I'm really glad to hear that you are interested in feedback. I presume you'd like the feedback in private since you didn't specifically state otherwise. If you'd like it to be public, you are welcome to forward any response to the brlcad-devel mailing list. On to your feedback... Let me start by saying that your application evaluation was the most difficult for me personally this year. If we had requested 8 slots, you probably would have been selected. You obviously wrote an excellent proposal, provided great detail, and engaged in discussions well. Multiple mentors were willing to take you on as a student. Your activity with LibreCAD was a huge plus. You could have done better with your communications by getting involved earlier, but overall you are pleasant and easy to work with which is great. I sincerely do hope you stay involved if for those reasons alone. The biggest detriment to your proposal was your patch submission. First was the type of patch you chose. You were proposing a very hard project, but your patch was a simple line reduction refactoring. Even the next patch you proposed was just fixing simple compilation errors. A hard project calls for an impressive patch. The simple refactoring would have been "okay" except that your patch then had several issues too. You were great responding to Rossberg's comments, but his feedback were all things that you could have noticed and corrected yourself. The other disappointing aspect of the patch was the lack of attention to detail. The first comment isn't indented properly and the two subsequent comments you added were completely useless/uninformative. The return values were a mess. :) The patch was your opportunity to shine and it really felt like you didn't put enough effort into it. Those were some of the contributing factors that resulted in your proposal not getting accepted this year. Please note that there is no shame in not getting selected. It is a competitive process and, again, your application was one of the most difficult to evaluate. The biggest advice I can give you is to just keep coding and pay attention to details. Every little detail. If there is any possible way to improve a piece of code, take the time and do it. Learn to see little discrepancies and inconsistencies. That attention to detail will translate into better code, more efficient programming, and fun work. This is not meant to be one-sided feedback. If you have questions or comments of your own, please don't hesitate to engage me or others in discussion. Myself and other developers are more than happy to help you become more involved with BRL-CAD. I would love to see you become a new contributor. You could start by making your existing patch "perfect". Sincerely, Sean On May 30, 2013, at 11:33 AM, Jasleen Kaur <[email protected]> wrote: On 30 May 2013 20:30, Christopher Sean Morrison <[email protected]> wrote: > On May 30, 2013, at 09:22 AM, Navdeep Bagga <[email protected]> wrote: > > On Tue, May 28, 2013 at 9:44 PM, Christopher Sean Morrison > <[email protected]> wrote: > >> I am more than happy to share specific proposal feedback for any student >> (accepted or rejected) on your proposal if you are interested. I will >> respond to any feedback requests in private, unless you specifically state >> otherwise that you'd like the feedback and any following discussion to be >> public. All you have to do is ask (if you've already asked, I will be >> responding ASAP). > > I would like to get feedback on my material database proposal. It > helps me to start working on it. > I also want to get feedback from you about my proposal "Cross Platform Display Manager". -- Jasleen Kaur [W] jasleenz.com [B] jasleen7956.wordpress.com ------------------------------------------------------------------------------ Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET Get 100% visibility into your production application - at no cost. Code-level diagnostics for performance bottlenecks with <2% overhead Download for free and get started troubleshooting in minutes. http://p.sf.net/sfu/appdyn_d2d_ap1 _______________________________________________ BRL-CAD Developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/brlcad-devel -- Jasleen Kaur [W] jasleenz.com [B] jasleen7956.wordpress.com ------------------------------------------------------------------------------ Get 100% visibility into Java/.NET code with AppDynamics Lite It's a free troubleshooting tool designed for production Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes. http://p.sf.net/sfu/appdyn_d2d_ap2 _______________________________________________ BRL-CAD Developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/brlcad-devel
