On Dec 7, 2013, at 9:01 AM, Tom Browder wrote:

> If I find one or more with differing signatures, what  should I do?
> My guess is: I should rework them to fit a common signature, even
> though they may have one or more UNUSED(x) wrappers around func args.

They should definitely be using a common signature.  The one you put into bu.h 
is "probably" the signature we want, with all four args const ... but can't say 
that for sure until they're all looked into.  There may be some that rely on 
non-constness (returning a value to the callee).

More than likely, though, const just needs to be put on all of the callback 
function arguments.  Might need to bu_strdup() in some places if the strings 
are written to, but you'll just have to keep an eye out for any callbacks that 
write to the arg and are using that write to pass information back to elsewhere 
in the logic.  If you can mark them all const without the compiler barking, 
then we're probably good.

Cheers!
Sean


------------------------------------------------------------------------------
Sponsored by Intel(R) XDK 
Develop, test and display web and hybrid apps with a single code base.
Download it for free now!
http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
_______________________________________________
BRL-CAD Developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-devel

Reply via email to