On Mon, Jan 6, 2014 at 9:53 PM, Deepak Sharma <deeky.sha...@gmail.com> wrote: > Hi everyone, > I've been lurking on the mailing list for a while. I wanted to finally > introduce myself. > This is Deepak,
Welcome to BRL-CAD. > I have started working on Online Geometry Viewer, my motive is to make > this editor as best editor on web. Currently i'm making mock-up for > Geometry viewer, I also made script for installation of Geometry > Viewer. Here is the link > http://202.164.53.122/~deepak/brlgeometry.tar.gz > Please review/test it. I run it, and it worked. Following is the review: 1. Script is not as per coding guidelines of BRL-CAD. Check HACKING file in source directory to learn more about community's coding standard. 2. I intentionally missed email address, but rather asking it again, it moved further. You need to put checks / validations to confirm whether the email address was entered and is in proper format. Same for other fields. 3. Passwords for email address and MySQL when entered are visible as text. 4. After entering correct email address and password and entering wrong MySQL credentials, it start asking everything from the beginning. Only current field should be asked. 5. The message "Username and password match" need to be changed. 6. On rerunning the script after removing previous installation, it installed successfully but database has not been updated to new. It is still referring to old one, so unable to register. 7. MySQL password is being asked two times. -- Harmanpreet Singh Blog: http://singhharman.wordpress.com/ ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ BRL-CAD Developer mailing list brlcad-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/brlcad-devel
