On Mon, Jan 6, 2014 at 11:11 PM, Harmanpreet Singh <harman...@gmail.com> wrote: > Welcome to BRL-CAD.
Thank you :) > 1. Script is not as per coding guidelines of BRL-CAD. Check HACKING > file in source directory to learn more about community's coding > standard. I converted script according to community standard but still i'm not pretty much confidence whether it is according to community standard or not. I need review on that, anyone please review it. Tell me the mistakes I committed in it, so that in near future it wouldn't happen again. > 2. I intentionally missed email address, but rather asking it again, > it moved further. You need to put checks / validations to confirm > whether the email address was entered and is in proper format. Same > for other fields. Done with this. > 3. Passwords for email address and MySQL when entered are visible as text. No more visible as text, I changed it to hidden scheme. > 4. After entering correct email address and password and entering > wrong MySQL credentials, it start asking everything from the > beginning. Only current field should be asked. Done with it. > 5. The message "Username and password match" need to be changed. What message should I add at that place, tell me? I changed it to "vaild username and password" is it look okay or we need to add something else. > 6. On rerunning the script after removing previous installation, it > installed successfully but database has not been updated to new. It is > still referring to old one, so unable to register. This is because when to try to install it first time, whatever information you added it got saved in config.php like database name, your e-mail ID, and passwords. Now you again triggering same file when you re-run the script, so it is picking old username and passwords. In order to avoid this, remove "geometry_viewer" both from /var/www and home folder, clean database you created, extract folder once again and try to re-run the script. Tell me whether you face same problem. > 7. MySQL password is being asked two times. It asked MySQL password twice because 1). When user going to create database, for login into MySQL it ask you for password. 2). After creating database, geo_viewer.sql need to upload in database (created by user) so in that case it pick username entered before and just for security reasons it ask sql password again. -- Deepak Kumar Sharma Blog: http://deekysharma.wordpress.com ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ BRL-CAD Developer mailing list brlcad-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/brlcad-devel
