On 14 March 2011 15:45, Jim Meyering <[email protected]> wrote: > Reuben Thomas wrote: >> This line in maint.mk: >> >> VC-tag = git tag -s -m '$(VERSION)' -u '$(gpg_key_ID)' >> >> does appear to be unused, because its syntax is wrong: there's no >> message (argument to -m), or equivalently, no tag name is specified. >> >> Is something like: >> >> VC-tag = git tag -s -m 'Sign version $(VERSION)' '$(VERSION)' -u >> '$(gpg_key_ID)'
[We fixed this, but...] > That definitely needs to be changed, or perhaps better, removed. Should it be removed? It's now correct, but it's not actually used anywhere. Better, perhaps, replace it with: > http://git.sv.gnu.org/cgit/coreutils.git/tree/README-release ? coreutils's README-release is a) a handy cheat-sheet, and b) a good source of things to automate. -- http://rrt.sc3d.org
