Reuben Thomas wrote: > On 14 March 2011 15:45, Jim Meyering <[email protected]> wrote: >> Reuben Thomas wrote: >>> This line in maint.mk: >>> >>> VC-tag = git tag -s -m '$(VERSION)' -u '$(gpg_key_ID)' >>> >>> does appear to be unused, because its syntax is wrong: there's no >>> message (argument to -m), or equivalently, no tag name is specified. >>> >>> Is something like: >>> >>> VC-tag = git tag -s -m 'Sign version $(VERSION)' '$(VERSION)' -u >>> $(gpg_key_ID)' > > [We fixed this, but...] > >> That definitely needs to be changed, or perhaps better, removed. > > Should it be removed? It's now correct, but it's not actually used
Sure. I've nuked it. Patch below. > anywhere. Better, perhaps, replace it with: > >> http://git.sv.gnu.org/cgit/coreutils.git/tree/README-release > > ? Not sure what the question is. I don't think we need to replace it with anything. > coreutils's README-release is a) a handy cheat-sheet, and b) a good > source of things to automate. >From e82aa5d1a3c12cf3bbc7148182a2d1af33aa209d Mon Sep 17 00:00:00 2001 From: Jim Meyering <[email protected]> Date: Fri, 29 Apr 2011 18:58:43 +0200 Subject: [PATCH] maint.mk: remove unused VC-tag variable * top/maint.mk (VC-tag): Remove unused variable. --- ChangeLog | 5 +++++ top/maint.mk | 1 - 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index 874a093..6dc1244 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2011-04-29 Jim Meyering <[email protected]> + + maint.mk: remove unused VC-tag variable + * top/maint.mk (VC-tag): Remove unused variable. + 2011-04-29 Bruno Haible <[email protected]> netdb: fix gai_strerror replacements diff --git a/top/maint.mk b/top/maint.mk index 47cb44e..8727b3f 100644 --- a/top/maint.mk +++ b/top/maint.mk @@ -33,7 +33,6 @@ GZIP_ENV = '--no-name --best $(gzip_rsyncable)' GIT = git VC = $(GIT) -VC-tag = git tag -s -m '$(VERSION)' 'v$(VERSION)' -u '$(gpg_key_ID)' VC_LIST = $(build_aux)/vc-list-files -C $(srcdir) -- 1.7.5.452.gcf2d0
