Hi Tim, Am 29.11.2019 um 10:16 schrieb Tim Rühsen <[email protected]>: > But first let's get the algorithm straight. > In modules/getaddrinfo (and some other modules) are 2 'Link' libraries > given: > > Link: > $(GETADDRINFO_LIB) > $(LTLIBINTL) when linking with libtool, $(LIBINTL) otherwise > > So "libgnu_la_LDFLAGS += $(GETADDRINFO_LIB) $(LTLIBINTL)" would be right > in the first place. But we don't want to add any of those libraries in > case libgnu_la_LDFLAGS already contain them (avoiding duplicates) !? > > Is that right ? > > And what about the order of libraries ? AFAIR, gcc/ld 9+ rely on the > correct order of libraries while older gcc/ld version doesn't.
From what I see the shellscript uses 'sort -u‘ on the flag additions. To match the shell behaviour there should be only variable per line or the '-u‘ for uniqueness of addition does not work. This is currently done with a set in Python which should do it, but getLinks currently returns a concatenated string instead of a list which leads to the observed error. Best regards — Dago -- "You don't become great by trying to be great, you become great by wanting to do something, and then doing it so hard that you become great in the process." - xkcd #896
signature.asc
Description: Message signed with OpenPGP
