Hi Bruno, On 30.11.19 13:06, Bruno Haible wrote: >> Please review the patch - surely some of my python constructs could be >> done more elegant. > > Review: > - GLModuleSystem.getLink: Looks good. This method corresponds to > func_get_link_directive and therefore should not do any joining or so, > just return a list of strings. > - GLEmiter.lib_Makefile_am: Looks good. > - GLImport.execute: Looks good as well. > > It corrects the issue reported by Dagobert. Therefore I'm pushing it in > your name. (I don't remember if you already have direct write access to > the gnulib repository, sorry.)
Thanks for reviewing and pushing ! I don't have write access, but that's fine as I just seldom contribute :-) > By the way, something in your environment apparently stripped the trailing > newline of the patch. As a consequence, I got this warning: > $ patch -p1 < .../pygnulib.diff > patching file pygnulib/GLEmiter.py > patching file pygnulib/GLImport.py > patching file pygnulib/GLModuleSystem.py > patch unexpectedly ends in middle of line > Hunk #2 succeeded at 806 with fuzz 1. There is one LF at the end of the diff file (taken from the email I received via mailing list, also cross-checked with bug-gnulib archive). Does patch expect 2 LF in this case ? Regards, Tim
signature.asc
Description: OpenPGP digital signature
