Hi Tim, > Please review the patch - surely some of my python constructs could be > done more elegant.
Review: - GLModuleSystem.getLink: Looks good. This method corresponds to func_get_link_directive and therefore should not do any joining or so, just return a list of strings. - GLEmiter.lib_Makefile_am: Looks good. - GLImport.execute: Looks good as well. It corrects the issue reported by Dagobert. Therefore I'm pushing it in your name. (I don't remember if you already have direct write access to the gnulib repository, sorry.) By the way, something in your environment apparently stripped the trailing newline of the patch. As a consequence, I got this warning: $ patch -p1 < .../pygnulib.diff patching file pygnulib/GLEmiter.py patching file pygnulib/GLImport.py patching file pygnulib/GLModuleSystem.py patch unexpectedly ends in middle of line Hunk #2 succeeded at 806 with fuzz 1. 2019-11-29 Tim Rühsen <[email protected]> gnulib-tool.py: Fix libgnu_la_LDFLAGS section in generated Makefile.am. Reported by Dagobert Michelsen <[email protected]> in <https://lists.gnu.org/archive/html/bug-gnulib/2019-11/msg00086.html>. * pygnulib/GLModuleSystem.py (getLink): Don't join the parts. Return a list of strings instead of one string. * pygnulib/GLEmiter.py (lib_Makefile_am): Adapt accordingly. * pygnulib/GLImport.py (execute): Likewise.
