On 2013-03-27 10:26, Roman Kennke wrote:
Am Mittwoch, den 27.03.2013, 09:55 +0100 schrieb Erik Joelsson:
Work on this was already initiated in this thread:
http://mail.openjdk.java.net/pipermail/build-infra-dev/2013-February/003059.html
Would be good if these efforts could be synchronized.
I like that you define and translate these hotspot specific variables in
hotspot-spec.gmk. I don't think we need to change any variables in
hotspot for this to work as was done in the other thread. ZERO_ARCHDEF
should maybe belong to platform.m4, not sure, but might as well be
defined where you have it. However, checking for libraries would be
better moved to libraries.m4 I think.
Yeah, sorry that I did not follow up on 'my' thread. It kindof fizzled
out. What's blocking the patches from going in?
http://cr.openjdk.java.net/~rkennke/zero_build_infra_hotspot/webrev.01/
I think it was the changes in hotspot that was blocking and those aren't
really needed IMO. A simple translation from configure naming of
variables to the hotspot naming in hotspot-spec.gmk.in should be enough
and follows the current model, like in Omair's patch.
I think the JDK part needs to be revisited now that the way JARs are
built has changed, but this can be done independently:
http://cr.openjdk.java.net/~rkennke/zero-build-infra-jdk/webrev.01/
Omair's patch fixed this.
I still prefer Roman's configure changes however. If all that could be
combined, I would be happy.
/Erik
