Hi, On 03/27/2013 04:55 AM, Erik Joelsson wrote: > Work on this was already initiated in this thread: > > http://mail.openjdk.java.net/pipermail/build-infra-dev/2013-February/003059.html >
Whoops. I was not aware of this. Thanks for pointing this out. > Would be good if these efforts could be synchronized. Yes, this would be great. I am happy to throw away all my changes and help improve Roman's patch. > I like that you define and translate these hotspot specific variables in > hotspot-spec.gmk. I had the feeling that my patch would become a lot less desirable if it started touching hotspot ;) > I don't think we need to change any variables in > hotspot for this to work as was done in the other thread. ZERO_ARCHDEF > should maybe belong to platform.m4, not sure, but might as well be > defined where you have it. However, checking for libraries would be > better moved to libraries.m4 I think. One thing worth pointing out is that my patch only addresses zero, while Roman's patch addresses both zero and shark. Roman, how do you want to proceed? Thanks, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681
