I'm not sure which is what but I'd like to see:
ifeq ($(INCLUDE_SA), true)
...
used.
Thanks,
David
On 28/03/2013 12:05 AM, Roman Kennke wrote:
Am Mittwoch, den 27.03.2013, 09:42 -0400 schrieb Omair Majid:
Hi,
On 03/27/2013 04:55 AM, Erik Joelsson wrote:
Work on this was already initiated in this thread:
http://mail.openjdk.java.net/pipermail/build-infra-dev/2013-February/003059.html
Whoops. I was not aware of this. Thanks for pointing this out.
Would be good if these efforts could be synchronized.
Yes, this would be great. I am happy to throw away all my changes and
help improve Roman's patch.
I like that you define and translate these hotspot specific variables in
hotspot-spec.gmk.
I had the feeling that my patch would become a lot less desirable if it
started touching hotspot ;)
I don't think we need to change any variables in
hotspot for this to work as was done in the other thread. ZERO_ARCHDEF
should maybe belong to platform.m4, not sure, but might as well be
defined where you have it. However, checking for libraries would be
better moved to libraries.m4 I think.
One thing worth pointing out is that my patch only addresses zero, while
Roman's patch addresses both zero and shark.
Roman, how do you want to proceed?
I'd go with Erik's suggestion and keep your part for JDK changes, and
mine for the rest, if that is ok with you?
Roman
