> On Mar 26, 2018, at 11:01 AM, Robin Westberg <robin.westb...@oracle.com> > wrote: > > Hi all, > > Please review this small change that defines the NOMINMAX macro when building > HotSpot on Windows. > > Issue: https://bugs.openjdk.java.net/browse/JDK-8199619 > Webrev: http://cr.openjdk.java.net/~rwestberg/8199619/webrev.00/ > <http://cr.openjdk.java.net/~rwestberg/8199619/webrev.00/> > Testing: building with/without precompiled headers, hs-tier1 > > Best regards, > Robin
Looks good. This change will have a (easy to resolve) merge conflict with your fix for JDK-8199736, right?
