I will sponsor the change.
/Erik
On 2018-03-28 06:43, Robin Westberg wrote:
Hi Kim,
On 26 Mar 2018, at 18:34, Kim Barrett <kim.barr...@oracle.com> wrote:
On Mar 26, 2018, at 11:01 AM, Robin Westberg <robin.westb...@oracle.com> wrote:
Hi all,
Please review this small change that defines the NOMINMAX macro when building
HotSpot on Windows.
Issue: https://bugs.openjdk.java.net/browse/JDK-8199619
Webrev: http://cr.openjdk.java.net/~rwestberg/8199619/webrev.00/
<http://cr.openjdk.java.net/~rwestberg/8199619/webrev.00/>
Testing: building with/without precompiled headers, hs-tier1
Best regards,
Robin
Looks good.
Thanks for reviewing!
This change will have a (easy to resolve) merge conflict with your fix for
JDK-8199736, right?
Indeed, the flag definitions should go on a single line I think. I’ll try to
get this one in first and rebase 8199736 afterwards.
So, if anyone would be willing to sponsor this change, here’s an updated webrev
with a proper mercurial changeset (no other changes):
http://cr.openjdk.java.net/~rwestberg/8199619/webrev.01/
<http://cr.openjdk.java.net/~rwestberg/8199619/webrev.01/>
Best regards,
Robin
