Hi Magnus, Thanks for the review!
Best regards, Robin > On 26 Mar 2018, at 23:24, Magnus Ihse Bursie <magnus.ihse.bur...@oracle.com> > wrote: > > On 2018-03-26 17:01, Robin Westberg wrote: >> Hi all, >> >> Please review this small change that defines the NOMINMAX macro when >> building HotSpot on Windows. >> >> Issue: https://bugs.openjdk.java.net/browse/JDK-8199619 >> Webrev: http://cr.openjdk.java.net/~rwestberg/8199619/webrev.00/ >> <http://cr.openjdk.java.net/~rwestberg/8199619/webrev.00/> > Looks good to me. > > /Magnus > >> Testing: building with/without precompiled headers, hs-tier1 >> >> Best regards, >> Robin >
