On Mon, 7 Oct 2024 14:09:39 GMT, Erik Joelsson <[email protected]> wrote:
>> Can I get a review for this patch that adds the necessary changes for local
>> support of the `tidy` library.
>>
>> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh`
>> on Linux and MacOs systems.
>>
>> This dependency is primarily going to be used to test the generated
>> documentation.
>>
>> This patch is meant to be integrated before #21272.
>>
>> Note: we need to be a very specific revision of `tidy` and cannot use any of
>> the available artifacts, as older versions do not recognize some HTML 5
>> elements.
>>
>> TIA
>
> make/conf/jib-profiles.js line 1284:
>
>> 1282: revision: "5.9.20+1",
>> 1283: environment_path: input.get("tidy", "home_path") +
>> "/tidy/bin/tidy",
>> 1284: configure_args: "TIDY=" + input.get("tidy", "home_path")
>> +"/bin/tidy",
>
> These paths are different. I'm guessing the latter one is corret?
Yes, the second one is correct. Will fix it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21341#discussion_r1790328208
