On Mon, 7 Oct 2024 14:08:49 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Can I get a review for this patch that adds the necessary changes for local >> support of the `tidy` library. >> >> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh` >> on Linux and MacOs systems. >> >> This dependency is primarily going to be used to test the generated >> documentation. >> >> This patch is meant to be integrated before #21272. >> >> Note: we need to be a very specific revision of `tidy` and cannot use any of >> the available artifacts, as older versions do not recognize some HTML 5 >> elements. >> >> TIA > > make/conf/jib-profiles.js line 456: > >> 454: target_os: "macosx", >> 455: target_cpu: "aarch64", >> 456: dependencies: ["devkit", "gtest", "graphviz", "pandoc", >> "tidy"], > > Is there a reason for not providing Tidy on macosx-x64? It looks like the > binary built by the script below would be a multi-arch variant. If so, you > should deploy it as just "tidy-html-macosx" and add some code in the > dependencies section below that defines "module" as just `"tidy-html" + > input.target_os` on macosx. I will update this after deploying for macosx-x64 and linux-aarch64. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21341#discussion_r1790347936
