On Thu, 10 Oct 2024 13:55:40 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
> I made a few changes based on the review comments. After a few iterations, I > now define module as `"tidy-html-" + input.target_os`. The dependency is > indeed multi arch so only one is needed for macos. When it's not too much work, we like to provide these kinds of dependencies on all platforms. Windows is obviously harder, but linux-aarch64 should be trivial. You can add a conditional, either inline using `? :` or by introducing a variable further up, and use target_os or target_platform based on if the os is macosx or not. That's what I would recommend. ------------- PR Comment: https://git.openjdk.org/jdk/pull/21341#issuecomment-2405737201
