On Fri, 11 Oct 2024 12:53:31 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
>> Can I get a review for this patch that adds the necessary changes for local >> support of the `tidy` library. >> >> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh` >> on Linux and MacOs systems. >> >> This dependency is primarily going to be used to test the generated >> documentation. >> >> This patch is meant to be integrated before #21272. >> >> Note: we need to be a very specific revision of `tidy` and cannot use any of >> the available artifacts, as older versions do not recognize some HTML 5 >> elements. >> >> TIA > > Nizar Benalla has updated the pull request incrementally with one additional > commit since the last revision: > > Add small comment to `createTidyBundle` make/RunTests.gmk line 742: > 740: $1_JTREG_PROBLEM_LIST := $$(filter $$($1_TEST_ROOT)%, > $$($1_JTREG_PROBLEM_LIST)) > 741: > 742: #setup tidy Suggestion: # Pass along the path to the tidy html checker ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21341#discussion_r1797089212
