On Wed, 27 Nov 2024 12:13:01 GMT, Ludvig Janiuk <lujan...@openjdk.org> wrote:
>> The output for Jtreg v7.5 was >> [enhanced](https://github.com/openjdk/jtreg/pull/217/files#diff-b6ab77bf651f1fd9a83c3ca0aab9cd24ae5c08cef41e6e257f7eaccc07c7c366R947) >> with [information about skipped >> tests](https://github.com/openjdk/jtreg/blob/master/src/share/doc/javatest/regtest/faq.md#what-do-all-those-numbers-in-the-test-results-line-mean). >> >> Use the additional information in the "summary" block printed at the end of >> `make test` target. > > make/RunTests.gmk line 1038: > >> 1036: $$(subst $$(TOPDIR)/, , $$($1_TEST_RESULTS_DIR)))) >> 1037: >> 1038: # Read Jtreg documentation to learn more about Jtreg report categories: > > Don't capitalize jtreg Thanks. Fixing this. > make/RunTests.gmk line 1041: > >> 1039: # >> https://github.com/openjdk/jtreg/blob/master/src/share/doc/javatest/regtest/faq.md#what-do-all-those-numbers-in-the-test-results-line-mean >> 1040: # In Jtreg's report, the tests "skipped:" at runtime still contribute >> to the "passed:" number. >> 1041: # In here we treat those "skipped:" tests similar to the ones which >> were filtered out (for various reasons). > > Best to expand on the reasons I agree. This is a bad wording. I edited the comment in my recent commit. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22245#discussion_r1860676565 PR Review Comment: https://git.openjdk.org/jdk/pull/22245#discussion_r1860675990
