On Mon, 2 Dec 2024 15:01:35 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Ivan Bereziuk has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove resorting zero-ing of $1_SKIPPED as preceding gawk always assigns >> the value > > make/RunTests.gmk line 1042: > >> 1040: # In jtreg, "skipped:" category accounts for tests that threw >> jtreg.SkippedException at runtime. >> 1041: # At the same time these tests contribute to "passed:" tests. >> 1042: # In here we don't want that and so we substract number of "skipped:" >> from "passed:". > > Can you please indent this to the level of the recipe line below (using space > and not tab, see (5) in > https://openjdk.org/groups/build/doc/code-conventions.html). Fixed. Thank you. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22245#discussion_r1867669422
